Speed up test_sorting_s3_nwb_zarr (again)#4538
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4538 +/- ##
=======================================
Coverage 70.17% 70.17%
=======================================
Files 354 354
Lines 43323 43323
=======================================
Hits 30403 30403
Misses 12920 12920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Success! Now: 
A couple of weeks ago: 
|
alejoe91
approved these changes
Apr 20, 2026
Collaborator
|
This is great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #4537 since can't run full tests from my branch.
While investigating the speed regression for full tests from #4515, I noticed that one of our longest tests test_sorting_s3_nwb_zarr was slow (before, took 4 minutes here https://github.com/SpikeInterface/spikeinterface/actions/runs/23709486678 and after, took 15 minutes here: https://github.com/SpikeInterface/spikeinterface/actions/runs/24629667731/job/72014705334 - the reason for this regression is still unknown).
The reason is that check_sortings_equal has to stream the entire file. We can prevent this by frame_sliceing, and only doing a check_sortings_equal to the time sliced sorting. Should speed our full test suite up by 10%!
Tests: https://github.com/SpikeInterface/spikeinterface/actions/runs/24675282457